Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add framed works filter to artwork screens #11435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MounirDhahri
Copy link
Member

@MounirDhahri MounirDhahri commented Jan 23, 2025

#hackathon

Description

This PR is a follow-up to artsy/metaphysics#6369 and https://github.com/artsy/gravity/pull/18481. It adds framed as a filter to artwork screens and hides it behind a feature flag.

Screen.Recording.2025-01-23.at.12.39.14.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • add framed works filter to artwork screens (behind ff - hackathon)- mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (add framed works filter to artwork screens (behind ff - hackathon)- mounir - MounirDhahri)

Generated by 🚫 dangerJS against 42cc57a

Copy link
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the sorting! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants