feat: add show only framed works filter #15108
Conversation
#1588 Bundle Size — 8.97MiB (-0.32%).4b6aed3(current) vs 41ddd7f main#1587(baseline) Warning Bundle contains 14 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1588 |
Baseline #1587 |
|
|---|---|---|
 Initial JS |
3.65MiB(-0.05%) |
3.65MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
53.74% |
43.59% |
| Chunks |
104 |
104 |
| Assets |
107 |
107 |
| Modules |
5831(-0.39%) |
5854 |
| Duplicate Modules |
515(-3.01%) |
531 |
| Duplicate Code |
3.97%(-2.7%) |
4.08% |
| Packages |
266 |
266 |
| Duplicate Packages |
13 |
13 |
Bundle size by type 2 changes 
1 regression 1 improvement
| Current #1588 |
Baseline #1587 |
|
|---|---|---|
| JS |
8.83MiB (-0.33%) |
8.86MiB |
| Other |
145.45KiB (+0.15%) |
145.23KiB |
Bundle analysis report Branch feat/support-framed-filtering Project dashboard
Generated by RelativeCI Documentation Report issue
| // but NOT as an alert criterion, so we remove it. | ||
| // (Alerts, by definition, stipulate forSale=true | ||
| // when they are created in Gravity.) | ||
| delete criteria.forSale | ||
| delete criteria.framed |
There was a problem hiding this comment.
thought (non-blocking): I think this makes sense for now. Maybe a product decision about whether this would be a desirable alert criteria, but we can always follow up on that.
| const enableShowOnlyFramedArtworksFilter = useFeatureFlag( | ||
| "onyx_only_framed_artworks_filter", | ||
| ) |
There was a problem hiding this comment.
Do we really need the feature flag? In case something goes wrong, we cand simply roll back the feature.
There was a problem hiding this comment.
FWIW I'm in favor of the feature flag. Gives us the ability to do more fine-grained QA (in staging, or per user) before launching. I love the velocity of Hackathon but I appreciate rolling things out intentionally like this 😄
There was a problem hiding this comment.
True, the feature flag gives more flexibility for the release (and frees us from having to follow the bug-free programming principle 😄).
The type of this PR is: feat
This PR adds show only framed works filter to artwork filters
This PR is a follow-up to artsy/eigen#11435, artsy/metaphysics#6369 and https://github.com/artsy/gravity/pull/18481
Screen.Recording.2025-01-23.at.15.18.50.mov