fix: event propagation for modal #11970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Fix
This PR solves [PROJECT-XX]
Description
This PR includes fix for the problem, which you can see in the demo video. This is due to the fact that the
ModalBasecomponent usescreatePortaland we are facing this problem (example with details)Problem
When you click on the modal content, the
clickevent is propagated to parents and theonClickhandlers are triggered. Navigation to the artwork page is performed in our case, since we render this modal inside theDetailscomponent and displays this modal when clicking on the heart iconDemo
demo.mp4