spike: saving artworks to lists on other grids #11978
Conversation
dimatretyak
force-pushed
the
dimatretyak/sandbox/saves
branch
from
ca3ef14
to
97baa1f
Compare
| {!!artworkEntityId && ( | ||
| <SelectListsForArtworkModalQueryRender | ||
| artworkID={artworkEntityId} | ||
| onClose={clearArtworkId} | ||
| onSave={handleSaveListsForArtwork} | ||
| /> | ||
| )} |
There was a problem hiding this comment.
This approach to displaying the modal helps us solve this and some other problems
dimatretyak
requested review from
dzucconi,
anandaroop,
damassi,
dblandin,
gkartalis and
nickskalkin
dimatretyak
changed the title
| showHoverDetails={showHoverDetails} | ||
| disableRouterLinking={disableRouterLinking} | ||
| to={to} | ||
| enableSaveButtonForLists |
There was a problem hiding this comment.
In the future, this prop will not be required and these changes will be propagated to all components (FlatGridItem, ShelfArtwork, etc)
| fragment SaveArtworkToListsButton_artwork on Artwork { | ||
| id | ||
| internalID | ||
| is_saved: isSaved |
There was a problem hiding this comment.
I think we can change that to:
| is_saved: isSaved | |
| isSaved |
|
@damassi the toast is top center in Force actually |
|
Ah, I thought that was only in a few spots, but most positions its at the bottom right (like in our other apps). Hm |
|
Just earlier today Ryan told me that design team has signed off on a global change to position the toasts in Force towards the bottom right of the viewport. Does anyone foresee complications? |
Co-authored-by: Anandaroop Roy <anandaroop.roy+github@gmail.com>
it is useful to know this. thank you for sharing this info! |
The type of this PR is: Spike
Review app: artwork-saving
Demo for saves page
demo-1.mp4
Demo for artist artworks page
demo-2.mp4