-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lib] Upgrade Relay to 9 #5934
[Lib] Upgrade Relay to 9 #5934
Conversation
Duplicate Sources / Packages - Duplicates found!
|
It seems that the relay typescript plugin doesn't yet support v10. I'm going to back the libraries down to v9 to see if that gets us green. |
611dfc7
to
4fbc04d
Compare
// @ts-ignore | ||
<HTML variant="mediumText" html={subtitle} mt={2} flexBasis="50%" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
That's a weird one. I wonder why these type errors popped up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're legit errors, was gonna tag @dzucconi about it when the PR is out of draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the error? I don't see it locally when I check out this branch
@@ -67,6 +67,8 @@ export const FeatureHeaderDefault: React.FC<FeatureHeaderDefaultProps> = ({ | |||
</Text> | |||
|
|||
{subheadline && ( | |||
// FIXME: `property 'size' is missing | |||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you just haven't yarn installed (size was in the old HTML)
Depends on: artsy/reaction#3621
This PR upgrades Relay to 9, en route to 10 (once 10 is stable and associated tooling has been upgraded).
Review App: https://relay-upgrade.artsy.net/
Todo