-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lib] Add relay-hooks #6115
[Lib] Add relay-hooks #6115
Conversation
|
||
export interface ArtistConsignButtonProps { | ||
artist: ArtistConsignButton_artist | ||
artist: ArtistConsignButton_artist$key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish this wasn't so, but /shrug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️ 👁️
Curious, they mention it in the docs but not why? It's linted at least?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember the reason, but I kind like it. I remember it made things easier when I has to pass relay data from one comp to another, using $key made it a bit cleaner. I know I'm not helping much here, but trust it, with some usage I feel you will agree too.
b1983b7
to
9abf1ce
Compare
Duplicate Sources / Packages - Duplicates found!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hooks 🙌
|
||
export interface ArtistConsignButtonProps { | ||
artist: ArtistConsignButton_artist | ||
artist: ArtistConsignButton_artist$key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember the reason, but I kind like it. I remember it made things easier when I has to pass relay data from one comp to another, using $key made it a bit cleaner. I know I'm not helping much here, but trust it, with some usage I feel you will agree too.
9abf1ce
to
9af6a81
Compare
It looks like there are also some interop issues where using a hooks query with the hoc pattern breaks things. Going to close this for now as consistency is best. |
@pvinis - note that I would have merged this just to keep options open, but as of right now there are some insurmoutable test issues we'd have to resolve that we don't have a clear path forward on. If / when someone wants to pick this back up, they can re-open / refer to this PR. |
Following on #5934, this adds relay-hooks to force and updates a component to use them.
Todo: