Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move out new_ds to arviz-stats #102

Merged
merged 1 commit into from
Nov 13, 2024
Merged

move out new_ds to arviz-stats #102

merged 1 commit into from
Nov 13, 2024

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Nov 6, 2024

@aloctavodia
Copy link
Contributor Author

Tests are failing because with the changes in this PR the plot depends on a function that needs to be imported from arviz-stats, the function is there but not in the release version we are using for tests.
Probably the easiest thing to do is just wait until a next release.

@OriolAbril
Copy link
Member

We can modify the dependencies to install arviz-stats from github:

"arviz-stats[xarray] @ git+https://github.com/arviz-devs/arviz-stats",
(which we have done multiple times). Otherwise we'd have to either release constantly or end up developing very slowly

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (60ca1bc) to head (dc5169f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   86.09%   86.04%   -0.05%     
==========================================
  Files          24       24              
  Lines        2855     2845      -10     
==========================================
- Hits         2458     2448      -10     
  Misses        397      397              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aloctavodia aloctavodia merged commit 12854cc into main Nov 13, 2024
4 checks passed
@aloctavodia aloctavodia deleted the psense_out branch November 13, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants