Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker instructions #1127

Merged
merged 8 commits into from
Apr 9, 2020
Merged

Update docker instructions #1127

merged 8 commits into from
Apr 9, 2020

Conversation

ahartikainen
Copy link
Contributor

@ahartikainen ahartikainen commented Mar 29, 2020

Description

Update docker functionality.

  • new requirements files
  • updated instructions for docs build
  • some small additions to contributing guide
  • deleted travis related scripts

Checklist

  • New features are properly documented (with an example if appropriate)?
  • Changes are listed in changelog

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1127 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   92.79%   92.81%   +0.01%     
==========================================
  Files          93       93              
  Lines        9158     9181      +23     
==========================================
+ Hits         8498     8521      +23     
  Misses        660      660              
Impacted Files Coverage Δ
arviz/plots/traceplot.py 97.33% <0.00%> (-1.26%) ⬇️
arviz/plots/backends/bokeh/traceplot.py 95.97% <0.00%> (-0.43%) ⬇️
arviz/plots/backends/matplotlib/traceplot.py 99.15% <0.00%> (+0.06%) ⬆️
arviz/plots/backends/bokeh/rankplot.py 93.33% <0.00%> (+1.66%) ⬆️
arviz/plots/rankplot.py 91.66% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afaec70...a41bf8e. Read the comment docs.

@ahartikainen
Copy link
Contributor Author

Can someone try this?

@ahartikainen
Copy link
Contributor Author

ok, I have updated Docker + container.

This now works with Windows too, I created powershell script to do the same stuff as sh file does.

powershell -File ./scripts/container.ps1 --clear-cache --shell

I also added jupyter notebook / lab so these could work

./scripts/container.sh --notebook
./scripts/container.sh --lab

There is also now docs building steps in the default environment. I think we could drop the environment and just use the default namespace? Or maybe it is better to stay in environment.

CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ahartikainen ahartikainen merged commit 3352a8a into master Apr 9, 2020
@ahartikainen ahartikainen deleted the update_docker branch May 12, 2020 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants