Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btn: macro should add a background to the button #451

Closed
vogella opened this issue May 24, 2016 · 3 comments
Closed

btn: macro should add a background to the button #451

vogella opened this issue May 24, 2016 · 3 comments
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.beta.1

Comments

@vogella
Copy link
Contributor

vogella commented May 24, 2016

It would be nice if the PDF output would add a themeable background color to a button. I think the relevant macro is convert_inline_button node.

I put up a proof of concept patch very soon but unforunately can't find an example in the existing inline macros for that. The other macros seem to follow another approach for styling so advice or update of my little proof of concept patch would be helpful.

Once this is fixed for buttons, I think a fix for improved kbd: support with a background color and a border should be trivial.
vogella added a commit to vogellacompany/asciidoctor-pdf that referenced this issue May 24, 2016
@vogella
resolves asciidoctor#451 which suggest to use a stylable background f…
24d43b7 
…or btn:

Currently just a test commit to trigger feedback how to set the background colof a text element
vogella added a commit to vogellacompany/asciidoctor-pdf that referenced this issue May 24, 2016
@vogella
resolves asciidoctor#451 which suggest to use a stylable background f…
aa8f345 
…or btn:

Currently just a test commit to trigger feedback how to set the background colof a text element
vogella added a commit to vogellacompany/asciidoctor-pdf that referenced this issue May 24, 2016
@vogella
resolves asciidoctor#451 which suggest to use a stylable background f…
38ac6f2 
…or btn:

Currently just a test commit to trigger feedback how to set the background color a text element
@vogella
Copy link
Contributor Author

vogella commented May 24, 2016

Test PR #452

@vogella
Copy link
Contributor Author

vogella commented Nov 14, 2016

Currently blocked by #350. @mojavelinux Any change to merge #350 for the next alpha?

@fap- FYI

@mojavelinux
Copy link
Member

Ideally, the theme should be able to control the appearance of the button. There will be some limitations, since we can't do things like a shadow, but if we support background color and border in addition to the normal font settings, it should provide a lot of flexibility.

While #350 has some nice ideas, that's not exactly how I plan to implement it. I don't like the hardcoded colors.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Nov 20, 2016
@mojavelinux
resolves asciidoctor#451 allow button to be styled, including backgro…
168711e 
…und and border

- add support for background-color, border-color, border-width, and border-radius styles for formatted text
- allow button style to be configured by theme
- move default content for button into theme
@mojavelinux mojavelinux self-assigned this Nov 20, 2016
@mojavelinux mojavelinux mentioned this issue Jul 8, 2019
Closed
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 8, 2019
@mojavelinux
resolves asciidoctor#451 allow button to be styled by theme
fe35ca4
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 8, 2019
@mojavelinux
resolves asciidoctor#451 allow button to be styled by theme
ef54f48
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 8, 2019
@mojavelinux
resolves asciidoctor#451 allow button to be styled by theme
d291354
@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Jul 8, 2019
@mojavelinux mojavelinux mentioned this issue Jul 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.beta.1
Development

No branches or pull requests
2 participants
@mojavelinux @vogella