-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for quoted text attributes (prefixed in square brackets) #350
Conversation
Hi, I did some changes to make underline, colors etc work as for the Asciidoctor HTML format. |
30c3a15
to
d71c846
Compare
d71c846
to
ec11657
Compare
ec11657
to
d71c846
Compare
Supports all the types listed in the examples for asciidoc: http://www.methods.co.nz/asciidoc/chunked/ch10.html I.e. work for underline, overline, line-through, colors, big and small.
Instead of creating the hash on every invocation of apply(), it is created once.
The keyboard keys now look more like keys.
dde6407
to
53612bd
Compare
Absence of line-through and underline and red and blue colours blocks the use of potential asciidoc-diff utility with asciidoctor-pdf |
I came over the same problem: I've tried to fix this issue and I think I've got a solution. As I never did Ruby programming neither know the ascidoctor architecture, below I describe the code changes I did. Pls feel free to comment. new:
added method in converter.rb
added lines in transform.rb added after line 225
I've just tested with some styling properties. If ok all of theming-guide should propably being added. |
0505610
to
48915ca
Compare
I'm cherry picking from this pull request to make the changes easier to track. I've implemented the underline and line-through roles thus far. I'm planning to map big and small to the base_font_size_large and base_font_size_small theme settings. I'm still thinking about the best way to handle the colors. |
Any progress on the color dealing in asciidoctor? |
any update on this? |
This has now been implemented, mainly as part of #368. The only thing not implemented is the background and border for custom roles. However, it wouldn't be too much effort to add it to the current implementation. If that's needed, let's pursue it as a separate issue. |
Supports all the types listed in the examples for asciidoc:
http://www.methods.co.nz/asciidoc/chunked/ch10.html
I.e. work for underline, overline, line-through, colors, big and
small.