This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
refactor: code block scope #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
languages-reload
branch
2 times, most recently
from
b744697 to
abb1fe4
Compare
|
I didn't know about the |
- all the code blocks can be immediately followed by other grammar. - fix bug with CSS code block Fix asciidoctor#20
|
Ran a couple of practical tests. Very nice improvements, none of which seem to be a breaking change. I'm up for a merge. |
|
Merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
I use
grammar.tokenizeLinesin the tests becausegrammar.tokenizeLinedoesn't work properly with multi-lines content.grammar.tokenizeLinegive false positive with multi-lines because it parse multi-lines as a single line.Fix #20, #39, #59