This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
Porting AsciiDoctor regex for monospace #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -381,8 +381,9 @@ | |||
| # | |||
| # `Text in {backticks}` renders exactly as entered, in `monospace`. | |||
| { | |||
| 'match': '(?<=^|\\s)`[^`]+`' | |||
| 'name': 'markup.raw.inline.asciidoc' | |||
| 'match': '(^|[^\\p{Word};:"\'`\\}])((?:\\[([^\\\\]]+?)\\])?`(\\S|\\S.*?\\S)`(?![\\p{Word}"\'`]))' | |||
There was a problem hiding this comment.
Now that we know we can use regexp groups like \p{Word}, we should probably start using them more consistently throughout the grammar. The benefit of these groups is that they are friendly to all languages (not just English).
|
If you don't have any remarks, is it possible to merge and the #58 ? |
|
👍 |
|
Did a couple of practical tests and merged. Nice refactor @ldez ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting the https://github.com/asciidoctor/asciidoctor/blob/v1.5.4/lib/asciidoctor.rb#L1177-L1178 to the grammar.
fix #38