Array#sliceにおいて空配列となる場合の引数の条件を修正 #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for js-primer ready! Built with commit 5fb0784 |
azu
reviewed
Aug 19, 2020
| @@ -310,7 +310,7 @@ console.log(array.slice(1, 4)); // => ["B", "C", "D"] | |||
| console.log(array.slice(1)); // => ["B", "C", "D", "E"] | |||
| // マイナスを指定すると後ろからの数えた位置となる | |||
| console.log(array.slice(-1)); // => ["E"] | |||
| // 第一引数 > 第二引数の場合、常に空配列を返す | |||
| // 第一引数 >= 第二引数の場合、常に空配列を返す | |||
| console.log(array.slice(4, 1)); // => [] | |||
There was a problem hiding this comment.
これ開始位置と終了位置が同じ場合の例が抜けてるってことですよね。
[1,2,3,4].slice(4,4) のようなケース。
// 第一引数と第二引数が同じ場合は、空の配列を返す
console.log(array.slice(1, 1)); // => []
// 第一引数 > 第二引数の場合、常に空配列を返す
console.log(array.slice(4, 1)); // => []のようにコードとして分けて書いてもいいかもしれないですね。
どっちがわかりやすいですかね?
There was a problem hiding this comment.
ご確認ならびにご提案ありがとうございます！
おっしゃる記載の方が分かりやすい（友人も同意見でした）ので、そちらで再修正しておきます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array#sliceでは第一引数と第二引数が同一の場合も空配列となるので、
その意味も含めて
>ではなく>=もしくは≧が良いと思います。ささいな修正で恐縮ですが、上から読んでいった時に気になったので提案させて頂きました。
（このレベルならIssueの方が良い、等あればお教えください。）
過去の議論としては #1163 とも関連すると思います。