Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array#sliceにおいて空配列となる場合の引数の条件を修正 #1244

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Array#sliceにおいて空配列となる場合の引数の条件を修正 #1244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c72706
sliceにおいて空配列となる場合の引数の条件を修正
jonpili Aug 19, 2020
5fb0784
sliceにおいて空配列となる場合の引数の条件の表示を分離
jonpili Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions source/basic/array/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,8 @@ console.log(array.slice(1, 4)); // => ["B", "C", "D"]
console.log(array.slice(1)); // => ["B", "C", "D", "E"]
// マイナスを指定すると後ろからの数えた位置となる
console.log(array.slice(-1)); // => ["E"]
// 第一引数と第二引数が同じ場合は、空の配列を返す
console.log(array.slice(1, 1)); // => []
// 第一引数 > 第二引数の場合、常に空配列を返す
console.log(array.slice(4, 1)); // => []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ開始位置と終了位置が同じ場合の例が抜けてるってことですよね。

[1,2,3,4].slice(4,4) のようなケース。

// 第一引数と第二引数が同じ場合は、空の配列を返す
console.log(array.slice(1, 1)); // => []
// 第一引数 > 第二引数の場合、常に空配列を返す
console.log(array.slice(4, 1)); // => []

のようにコードとして分けて書いてもいいかもしれないですね。

どっちがわかりやすいですかね?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご確認ならびにご提案ありがとうございます！

おっしゃる記載の方が分かりやすい（友人も同意見でした）ので、そちらで再修正しておきます。

```
Expand Down