-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter #17
Add filter #17
Conversation
@tpgmartin great job! 👍 |
Thanks guys, and my apologies for the delay! I'm just curious to understand the use case a bit more. Would you guys mind sharing what you ignore? |
@aseemk I have two very similar use-cases from two different projects. 1. Base class Suppose, I have a Now I want to add an index file to require all my classes (except for the base class). I don't want to require the base class for two reasons:
2. Having both generalized and ready-to-use root modules Suppose, I have a Now I want to add two root modules to use them in different situations:
Later I'll use generalized factory module in my tests (to run them with different DB configurations), while the rest of my project will use already bootstrapped models provided by an index file. But to do so I'll have to ignore my index file when reading my |
Thanks. Now depending on this fork for my project. Would love to see it merged in. |
Sorry folks, I've been unusually busy with both work and life for a sustained period of time now. I keep meaning to get to these PRs (and other projects), but don't find myself with the time + energy too often. One thing I've done with another project is to invite one or two other people to be collaborators in the project and help maintain it. Anyone here interested in that? I'd just ask that you be mindful of keeping this project focused, and not let it get too complex. E.g. I'm not 100% sure it's a good idea to accept all of the currently open PRs, but I haven't looked into them fully or thought deeply about it. Apologies again for the delay, and thank you for understanding. =) |
No need to apologize; you're volunteering your time. I appreciate the offer to add a collaborator, but also don't have time to take on maintenance at the moment. Hopefully somebody will be able to pick this up. Thanks again! |
So, any progress here? By the way, another |
Hi there, I'm sorry I haven't been timely in responding to these issues and PRs. If you're interested in taking over the maintainer role for this project, please let me know. More details: #31 (comment) Cheers, |
Hi (new maintainer) - I've merged #27 which does the same thing, and was the first PR submitted to solve this problem. You should be able to achieve the same functionality with that. I'll be publishing it to npm shortly. |
This is in relation to this issue #14