Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a filter option to exclude particular files #27

Merged
merged 2 commits into from
Feb 7, 2018

Conversation

lennym
Copy link
Contributor

@lennym lennym commented Dec 23, 2015

We're using require-dir to load a directory of gulp tasks. However, we want to be able to exclude certain files from being required when executed in a production environment as they include dependencies that might not be installed.

Being able to apply a filter like function (f) { return process.env.NODE_ENV !== 'production' && !f.match(/$dev/); } would mean we can just ignore any dev-only task from the directory when run in a prod environment.

We're using require-dir to load a directory of gulp tasks. However, we want to be able to exclude certain files from being required when executed in a production environment as they include dependencies that might not be installed.

Being able to apply a filter like `function (f) { return process.env.NODE_ENV !== 'production' && !f.match(/$dev/); }` would mean we can just ignore any dev-only task from the directory when run in a prod environment.
@aseemk
Copy link
Owner

aseemk commented Jan 20, 2016

Sorry folks, I've been unusually busy with both work and life for a sustained period of time now. I keep meaning to get to these PRs (and other projects), but don't find myself with the time + energy too often.

One thing I've done with another project is to invite one or two other people to be collaborators in the project and help maintain it. Anyone here interested in that?

I'd just ask that you be mindful of keeping this project focused, and not let it get too complex. E.g. I'm not 100% sure it's a good idea to accept all of the currently open PRs, but I haven't looked into them fully or thought deeply about it.

Apologies again for the delay, and thank you for understanding. =)

@bondden
Copy link

bondden commented Jan 26, 2016

Anyone here interested in that?

Yes

@aseemk
Copy link
Owner

aseemk commented Oct 24, 2016

( @bondden: I missed your reply! Are you still interested? )

Hi there,

I'm sorry I haven't been timely in responding to these issues and PRs.

If you're interested in taking over the maintainer role for this project, please let me know.

More details: #31 (comment)

Cheers,
Aseem

@yocontra yocontra merged commit 1da3990 into aseemk:master Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants