Weird conditional

[davertay]

Is this a typo where the second condition is meant to be height instead of width?
https://github.com/ashfurrow/Nimble-Snapshots/blob/master/DynamicSize/DynamicSizeSnapshot.swift#L71

Updating this with a secondary query. A few lines before this layoutIfNeeded() is called, however as setNeedsLayout() is not called first it is almost guaranteed that the conditional view.bounds.width != size.width will fail.

So then my question really changes to: can this entire "iOS 9+ BUG" hack be avoided by tripping the setNeedsLayout() flag instead?

[ashfurrow]

Hmm, good question. I think it is a typo, but I'm not sure about the rest. @marcelofabri what do you think?

[marcelofabri]

This looks weird in fact. I think it should be height. Maybe @BrunoMazzo can give some insights for the whole "iOS 9+ BUG" section too as he was the original author?

[BrunoMazzo]

It's appear to be really a typo. Please change it to height.

But I do believe that adding setNeedsLayout() and removing the condition will break the feature for iOS 9. I tried here, it's simple, just run all tests on a iPhone 6 iOS 9.3 to see. The bug is that on iOS 9 auto-layout do not work on views that don't have a superview or a window (I don't remember exactly). I don't now why and don't have the link where a found about it.

But feel free to change anything! Just run the test on iOS 9, if it pass it's OK. If you find another solution I will be very glad (I really don't like this bug fix, it's a ugly if, 😢).

[Vkt0r]

I think we can close this as #145 solved