Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #145 fixed check to use both height and width instead of just width #148

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

davertay
Copy link

#145

Consensus is that this was a typo.

@ashfurrow
Copy link
Owner

Hmm, redundant Danger warnings are redundant.

@davertay thanks for the PR! Could I ask you to add a note to the changelog, with a link to #145?

Copy link
Owner

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Looks good. I won't be able to release a new version until Monday, unless @marcelofabri is free to do so sooner (no pressure!).

@ashfurrow ashfurrow merged commit d2b1f27 into ashfurrow:master Mar 16, 2018
@ashfurrow-peril
Copy link

Thanks a lot for contributing @davertay! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by 🚫 dangerJS

@ashfurrow
Copy link
Owner

This has been released as 6.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants