Release 1.4.0 #322
Release 1.4.0 #322
Conversation
* Add _pipeline_wrapper.py
| args: [--in-place, --wrap-summaries, "99", --wrap-descriptions, "92"] | ||
| args: [--in-place, --wrap-summaries=99, --wrap-descriptions=99] | ||
|
|
||
| # python check (PEP8), programming errors and code complexity |
There was a problem hiding this comment.
Consider moving the configurations here to pyproject.toml (I saw you created one)
See also in Lightning-AI
https://github.com/Lightning-AI/lightning/blob/master/pyproject.toml
https://github.com/Lightning-AI/lightning/blob/master/.pre-commit-config.yaml
There was a problem hiding this comment.
The problem is some linters don't support pyproject.toml meaning we still need to configure them through .pre-commit-config.yaml
For example, flake8 devs won't implement it.
For simplicity I decided to configure all pre-commits in .pre-commit-config.yaml only, but I'm open to PRs if you think it's really worth it
|
Took longer than expected due to lack of time on my part, but the PR seems to be finished. I will merge it after experimenting a bit more with DPP. |
No description provided.