Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering of images with an empty alt #34

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

jeisses
Copy link
Contributor

@jeisses jeisses commented Oct 12, 2024

Hi, first of all thanks for creating this great library! I love the no dependency approach.

This is a small fix that supports rendering links and images without an alt. With this change, the following will work:

(clarktown/render "![](https://example.com)")
"<p><img src=\"https://example.com\" alt=\"\"></p>"

I believe that to be the expected behavior of a markdown parser.

Copy link
Owner

@askonomm askonomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🙌

@askonomm askonomm merged commit 2ef2745 into askonomm:master Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants