Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rendering of images with an empty alt #34

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Support rendering of images with an empty alt #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/clarktown/renderers/link_and_image.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"Renders all occurring links and images."
[block _ _]
(loop [block block
matches (-> (re-seq #"\!?\[([a-zA-Z0-9\-\_\.\,\']+( [a-zA-Z0-9\-\_\.\,\']+)*)\]\((.*?)\)" block)
matches (-> (re-seq #"\!?\[([a-zA-Z0-9\-\_\.\,\']*( [a-zA-Z0-9\-\_\.\,\']+)*)\]\((.*?)\)" block)
distinct)]
(if (empty? matches)
block
Expand Down
5 changes: 4 additions & 1 deletion test/clarktown/renderers/link_and_image_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@

(testing "Creating an image"
(is (= (link-and-image/render "![This is an image](https://example.com)" nil nil)
"<img src=\"https://example.com\" alt=\"This is an image\">"))))
"<img src=\"https://example.com\" alt=\"This is an image\">"))

(is (= (link-and-image/render "![](https://example.com)" nil nil)
"<img src=\"https://example.com\" alt=\"\">"))))