chore(copybara): sync commits from Aspect-internal silo #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced from #500 by joelMuehlena: fix: tsconfig paths are not expanded correctly for tsconfigs and libs not placed at workspace root (#499) --- Fix #499 ### Test plan - Covered by existing test cases - New test cases added ### General This fix ensures, that if an expanded import path like specified in the corresponding tsconfig.json (of a file which for example lays in the following space <root>/projects/p1) is not absolute e.g. `@org/liba/* -> ./*: @org/liba/test` will be expanded to `projects/p1/test`. Otherwise gazelle has issues resolving the correct imports. Closes #500 --------- Co-authored-by: Joel Mühlena <joel.rene@muehlena.de> GitOrigin-RevId: 57f6b0b18df932cc543d334b4eac1118e70674cf
# Description This allows faster iteration on the outputs command for bb-clientd in the workflows plugin. By having it built from source, we can push changes to a PR, and the workflows plugin will be used from HEAD. # Type of change - [ ] Bug fix (change which fixes an issue) - [x] New feature or functionality (change which adds functionality) - [ ] Style (white-space, formatting, etc...) - [ ] Refactor (a code change that neither fixes a bug or adds a new feature) - [ ] Performance (a code change that improves performance) - [ ] Documentation (updates to documentation or READMEs) - [ ] Chore (any other change that doesn't affect source or test files) # Properties of change - [ ] Breaking change (this change will cause existing functionality to not work as expected) - [ ] This change requires a documentation update # Test plan How has this been tested? - [ ] Covered by existing tests cases - [ ] New test cases added - [x] Manual testing Built the CLI locally and tested that changes to the workflows plugin are picked up on subsequent runs. --------- Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> Co-authored-by: Derek Cormier <derek@aspect.dev> GitOrigin-RevId: da0f3a43a62edf9c5e03a4086bb6dacac9d31a5a
### Type of change - New feature or functionality (change which adds functionality) ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: 1- run `bazel run //workflows/rosetta/src:vendor_rosetta_for_dev` to check in rosetta changes 2- add `bb_clientd_acc_delivery` to delivery branches 3- invoke CI manually on `bb_clientd_acc_delivery` to enable the delivery step GitOrigin-RevId: 307196e7a98279f440542f8cd97b9406c62ef00a
Looks like this regressed in #1855 on the build plugin from source refactor. --- ### Type of change - Bug fix (change which fixes an issue) ### Test plan - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: 4ec910c54d20d9439668f70f0e89d7fc3a2e8c81
If you're relying on the stdout to parse the results out the outputs command then these warnings printed to stdout will get in the way. --- ### Type of change - Bug fix (change which fixes an issue) ### Test plan - Manual testing; please provide instructions so we can reproduce: Tested the output locally. GitOrigin-RevId: 3be609f6af2e971033d35b89ed496ee38a1549f4
…e it doesn't print anything (#3232) If found the name of this function deceiving when I was reading through this code. --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases GitOrigin-RevId: c83173a0e24137d9accbdc886c20a075cb99062d
…ession can be passed (#3230) Pre-factored out of aspect-build/silo#3227. --- ### Type of change - Documentation (updates to documentation or READMEs) ### Test plan - Covered by existing test cases GitOrigin-RevId: 0261b8b9be62a22599f9e5afe6e3126638fee166
Just some comment & error strings cleanups. --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) GitOrigin-RevId: c554a6fa82dcbe3a94803aacea745705a32ef973
When `support` was removed from OSS cli, not all the code was moved over. --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases - Manual testing Verified that support was not in the OSS cli help and that it still shows up in the pro cli help GitOrigin-RevId: 9f0ff19f97ccb97f088ea414990b297559a6b0bb
Fixes #365. --- ### Type of change - Bug fix (change which fixes an issue) **For changes visible to end-users** - Suggested release notes are provided below: Aspect CLI outputs command now accepts all Bazel aquery flags since `outputs` makes a `bazel aquery` call under the hood. ### Test plan - Manual testing; please provide instructions so we can reproduce: Manually tested that I could pass `--invocation_id` to an `aspect outputs` call. GitOrigin-RevId: d22ba7a2905db94fe610b7d552f9e0b61a8fcf84
For robustness, if the Bazel exit code is non-zero the bazelisk.Run() command should set `err` for callers that check `err` but don't check `exitCode` --- ### Type of change - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases GitOrigin-RevId: 110c3b0e9b68153bbd48ca25f8b4c47bf51ff1d1
…to plugin building/downloading/running (#3237) This should make it clear that the plugin is being built & run from source on CI & locally. --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Check CI that the new logs show up. GitOrigin-RevId: e742fdcaf389d303f3cdffdf759d4a7121062d87
There are fundamental issues with registering commands from plugins atm that would be more difficult to fix than to just move the outputs-bbclientd command to the "pro" CLI that we're using with Workflows. This PR does that and also fixes flag parsing bug for both `outputs` and `outputs-bbclientd` commands. See https://aspect-build.slack.com/archives/C03LXS06TA7/p1692400922783229 thread for more context on this change. --- ### Type of change - Bug fix (change which fixes an issue) ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: Ran, ``` bazel-bin/cli/pro/pro_/pro --aspect:lock_version outputs-bbclientd -- 'attr("tags", "\bdeliverable\b", //...)' ExecutableHash ``` locally GitOrigin-RevId: d17541b726688bddc7d100dfa629f40dd01dded7
|
I want to sync the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/dc6e3f9df4b286b3417a45c73b9dfa7a0500911a..57f6b0b18df932cc543d334b4eac1118e70674cf