Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: offer to install copier #149

Merged
merged 7 commits into from
Sep 23, 2024
Merged

chore: offer to install copier #149

merged 7 commits into from
Sep 23, 2024

Conversation

alexeagle
Copy link
Member

@alexeagle alexeagle commented Sep 21, 2024

Refactors to use the post_scaffold hook to generate the requirements.txt files, because it's too difficult to keep their content known ahead-of-time and prevents conditionals in the pyproject.toml for which packages should be installed.
We want to be responsive to prompts and be able to install packages if requested.

Also run buildifier in the post_scaffold hook, now we don't have to treat the whitespace in the template with incredible care :)

Note, the post_scaffold hook feature was introduced in v0.1.0 of the scaffold tool in hay-kot/scaffold#167 so we have to drop support for older versions now.

@alexeagle alexeagle force-pushed the copier branch 18 times, most recently from cb1a3ce to 2fd7998 Compare September 21, 2024 18:07
@alexeagle alexeagle changed the title chore: python app using copier chore: install copier when python selected Sep 21, 2024
@alexeagle alexeagle requested a review from thesayyn September 21, 2024 18:13
@thesayyn
Copy link
Member

Also run buildifier in the post_scaffold hook, now we don't have to treat the whitespace in the template with incredible care :)

I like this

@thesayyn
Copy link
Member

I briefly mentioned to @jbedard about how it is confusing to know which order to invoke go mod tidy bazel mod tidy and all other package manager related functions.

Would be great to have a feature in aspect-cli that does it for you automatically, like bazel configure lock which tracks package manager files and prompts to run a command similar to Android Studio Gradle Sync Now button.

@alexeagle
Copy link
Member Author

Yeah that's what repin.sh is trying to hint at here. It should include Go also.

@alexeagle alexeagle marked this pull request as ready for review September 21, 2024 18:21
@alexeagle alexeagle changed the title chore: install copier when python selected chore: offer to install copier Sep 22, 2024
@alexeagle alexeagle merged commit fb4ea9e into main Sep 23, 2024
9 checks passed
@alexeagle alexeagle deleted the copier branch September 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants