Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support post scaffold hooks #167

Merged
merged 9 commits into from
Jun 3, 2024
Merged

feat: support post scaffold hooks #167

merged 9 commits into from
Jun 3, 2024

Conversation

hay-kot
Copy link
Owner

@hay-kot hay-kot commented Jun 2, 2024

Notable Changes from Original PR

  • Uses settings pattern similar to the new theme config.
  • Moves flag to base command similar the other settings overrides
  • Moves some files around
  • Supports prefix style matches so hooks can have extensions
  • Adds a bit more documentation
  • Changes default to prompt

Also See

@hay-kot
Copy link
Owner Author

hay-kot commented Jun 2, 2024

@izeau - I made some changes on top of your PR. Mostly just preference/style things. Let me know if you have any thoughts!

@hay-kot hay-kot marked this pull request as ready for review June 2, 2024 18:22
@izeau
Copy link
Contributor

izeau commented Jun 2, 2024

Well that's really great - and a bit humbling if I'm being honest. I'm thankful that you took the time to review and improve this, and sorry you had to rework it that much!

@hay-kot
Copy link
Owner Author

hay-kot commented Jun 3, 2024

and a bit humbling if I'm being honest

I wouldn't feel too bad. Really the only thing I changed that wasn't a 'same thing but my way' kind of change was the matching prefixes thing. everything else you wrote was perfectly fine!

@hay-kot hay-kot merged commit f5c09cd into main Jun 3, 2024
1 check passed
@hay-kot hay-kot deleted the feat/hooks-pr-reloaded branch October 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants