Skip to content

Commit

Permalink
fix: remove other attributes that don't belong on js_binary
Browse files Browse the repository at this point in the history
Missed these in #110
  • Loading branch information
alexeagle committed Mar 23, 2023
1 parent e78c811 commit 3412dde
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions jest/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,11 @@ def jest_test(
**kwargs
)

# Remove named params that only apply to *_test rules.
# See https://bazel.build/reference/be/common-definitions#common-attributes-tests
for key in ["flaky", "shard_count", "local", "env", "env_inherit"]:
kwargs.pop(key)

update_snapshots_mode = None
if snapshot_files:
update_snapshots_mode = "files"
Expand Down

0 comments on commit 3412dde

Please sign in to comment.