fix: timeout/size shouldn't be passed to js_binary #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #95 BREAKING CHANGE: The default timeout for jest_test is now short (1m by default) rather than moderate (5m by default). Tests that take more than 1m should have a size or timeout attribute added.
jbedard
approved these changes
Mar 21, 2023
jhchabran
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Mar 22, 2023
This commit contains a fix that enables to pass a timeout to `jest_test` even if configured to use snapshots. See aspect-build/rules_jest#110 [force-bazel]
jhchabran
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Mar 22, 2023
…#49784) See aspect-build/rules_jest#110, which fixes the timeout issue that we've seen on `//client/web:test`. ## Test plan <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles --> CI ## App preview: - [Web](https://sg-web-jh-bump-rules-jest.onrender.com/search) Check out the [client app preview documentation](https://docs.sourcegraph.com/dev/how-to/client_pr_previews) to learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95
BREAKING CHANGE:
The default timeout for jest_test is now short (1m by default) rather than moderate (5m by default).
Tests that take more than 1m should have a size or timeout attribute added.