-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: Support timeout
option
#95
Comments
This seems to be working as intended for me. At HEAD (e6e9cfd) I made one test take over a minute. With Here's my repro: |
okay I pushed another commit to that branch, it's only reproducible with |
Fixes #95 BREAKING CHANGE: The default timeout for jest_test is now short (1m by default) rather than moderate (5m by default). Tests that take more than 1m should have a size or timeout attribute added.
Fixes #95 BREAKING CHANGE: The default timeout for jest_test is now short (1m by default) rather than moderate (5m by default). Tests that take more than 1m should have a size or timeout attribute added.
Fixes #95 BREAKING CHANGE: The default timeout for jest_test is now short (1m by default) rather than moderate (5m by default). Tests that take more than 1m should have a size or timeout attribute added.
What is the current behavior?
Currently there is no timeout attribute on this rule. Internally, we have some references to
rules_nodejs
jest_test we wrote that supports passing the timeout attribute to the rule https://bazel.build/reference/be/common-definitions#test.timeout. This is particularly useful for longer running targets until we migrate them to be smaller. Having this would ease our migration pathDescribe the feature
Given a
jest_test
rule, take an attribute calledtimeout
that passes along the values described here https://bazel.build/reference/be/common-definitions#test.timeoutFund our work
The text was updated successfully, but these errors were encountered: