ci: build and run unit tests with bzlmod #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
added
wip
kormide
commented
Feb 19, 2023
kormide
commented
Feb 19, 2023
kormide
commented
Feb 19, 2023
kormide
commented
Feb 19, 2023
kormide
removed
the
wip
kormide
force-pushed
the
ci-bzlmod
branch
6 times, most recently
from
10e4fb2
to
9edb182
Compare
|
Ready for review |
kormide
force-pushed
the
ci-bzlmod
branch
3 times, most recently
from
bb03012
to
def2dd7
Compare
kormide
commented
Feb 22, 2023
kormide
force-pushed
the
ci-bzlmod
branch
2 times, most recently
from
c1cd040
to
50b0661
Compare
|
Node toolchain fixes are in. This one is ready for another review @gregmagolan @alexeagle. |
kormide
commented
Feb 25, 2023
alexeagle
approved these changes
Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
This should close off the bzlmod support for rules_js ticket.
Depends on: bazel-contrib/bazel-lib#375