Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes needed for rules_js bzlmod support #375

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Changes needed for rules_js bzlmod support #375

merged 2 commits into from
Feb 21, 2023

Conversation

kormide
Copy link
Collaborator

@kormide kormide commented Feb 19, 2023 •
edited
Loading

@kormide kormide mentioned this pull request Feb 19, 2023
Merged
@kormide kormide changed the title Changes needed rules_js bzlmod support Changes needed for rules_js bzlmod support Feb 19, 2023
gregmagolan
gregmagolan reviewed Feb 19, 2023
View reviewed changes
lib/extensions.bzl Outdated Show resolved Hide resolved
@gregmagolan gregmagolan added the enhancement New feature or request label Feb 19, 2023
@kormide
Copy link
Collaborator Author

kormide commented Feb 21, 2023

Ready for another review pass.

@kormide
Copy link
Collaborator Author

kormide commented Feb 21, 2023

@alexeagle @aspect_bazel_lib_host is an optional repository that bazel-lib can set up to expose things like the bazel version and os/platform. It's currently depended upon by rules_js, so it needs to be made available via the module extension.

alexeagle
alexeagle approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks!

@kormide kormide merged commit 83fb305 into bazel-contrib:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kormide @alexeagle @gregmagolan