Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in the global.json file, use this to control SDK versions #729

Closed
natemcmaster opened this issue Aug 9, 2018 · 3 comments
Closed

Check in the global.json file, use this to control SDK versions #729

natemcmaster opened this issue Aug 9, 2018 · 3 comments
Labels
arcade cost: M Will take from 3 - 5 days to complete PRI: 2 - Preferred Preferably should be handled during the milestone. wontfix
Milestone
3.0.0

Comments

@natemcmaster
Copy link
Contributor

Part of incremental changes to move to arcade. dotnet/arcade#88

@ryanbrandenburg prototyped checking in the global.json file instead of generating it on the fly. (#661). Let's finish up this implementation and switch to using it to match what Arcade does.
@natemcmaster natemcmaster added cost: M Will take from 3 - 5 days to complete PRI: 2 - Preferred Preferably should be handled during the milestone. labels Aug 9, 2018
@natemcmaster natemcmaster mentioned this issue Aug 10, 2018
Closed
2 tasks
@natemcmaster natemcmaster mentioned this issue Oct 3, 2018
Merged
dougbu added a commit to aspnet/Mvc that referenced this issue Oct 4, 2018
@dougbu
Use Internal.AspNetCore.Sdk as an MSBuild SDK
2ac5e74 
- should resolve issues with occasional strange MSBuild caching issues in this repo
- modeled after dotnet/Scaffolding#905
- follows aspnet/BuildTools#729 recommendation to check in global.config file
  - see also dotnet/msbuild#2914
@dougbu dougbu mentioned this issue Oct 4, 2018
Closed
natemcmaster added a commit to dotnet/Scaffolding that referenced this issue Oct 4, 2018
@natemcmaster
Use Internal.AspNetCore.Sdk as an MSBuild SDK (#905)
ba6e9f5 
Convert from using Internal.AspNetCore.Sdk as a package reference to using it as an MSBuild SDK. This gives Internal.AspNetCore.Sdk more control over the projects and how they operation. MSBuild SDKs evaluate before restore, and can alter MSBuild settings which packages cannot.

cref aspnet/BuildTools#729
dougbu added a commit to aspnet/Mvc that referenced this issue Oct 4, 2018
@dougbu
Use Internal.AspNetCore.Sdk as an MSBuild SDK
5bddd22 
- should resolve issues with occasional strange MSBuild caching issues in this repo
- modeled after dotnet/Scaffolding#905
- follows aspnet/BuildTools#729 recommendation to check in global.config file
  - see also dotnet/msbuild#2914
- use newer KoreBuild
  - `.\build.cmd -update /t:noop`
@natemcmaster natemcmaster added this to the 3.0.0 milestone Oct 10, 2018
@dougbu
Copy link
Member

dougbu commented Feb 13, 2019

@natemcmaster global.json is checked into all four of our repos, at least in our master branches. And, those files specify the SDK.

What work remains here?

@natemcmaster
Copy link
Contributor Author

Two changes needed to complete this:

  1. Update Korebuild to read global.json to find the .NET Core SDK version it should install
  2. Decouple KoreBuild from the version of the .NET Core SDK (harder than it sounds)

At this point, only the aspnet/AspNetCore repo is using KoreBuild, so I would be fine if we didn't do this. Seems like a low priority.

@natemcmaster
Copy link
Contributor Author

At this point, I think this investment is not worth it. We only have one repo left using KoreBuild, and we plan to move it to Arcade soon.

Closing as 'wontfix'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arcade cost: M Will take from 3 - 5 days to complete PRI: 2 - Preferred Preferably should be handled during the milestone. wontfix
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@natemcmaster @dougbu