Reacting to verbose rename #112
Conversation
|
Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
| { | ||
| return IsLogLevelEnabledCore(logger, LogLevel.Verbose); |
There was a problem hiding this comment.
Why is this not Debug? or an intentional behavior change?
There was a problem hiding this comment.
Based on your other PR (logging) comment, this makes sense to me now...but the above LoggingExtensions.cs changes rename Verbose to Debug?
There was a problem hiding this comment.
This is an api change. There is already an IsDebugLevelEnabled function. The only thing that needs to change here is Verbose to Trace so every level has a corresponding helper function.
|
@kichalla I was wondering if you still had questions for this one? |
|
|
Reacting to aspnet/Logging#314.
Tested locally.