This repository was archived by the owner on Dec 13, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 245
Renaming LogLevel.Verbose to Trace #299 #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
c2ac8af
to
7a05d12
Compare
This was referenced Dec 7, 2015
cc @kichalla |
I am a bit confused...the title says Verbose is becoming Trace, but the above statement is different...which is correct? |
This was referenced Dec 7, 2015
|
This was referenced Dec 7, 2015
All PRs are out. I'll start merging and keeping an eye on the CI. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #299
Renaming
LogLevel
s in logging so thatVerbose
is renamed toTrace
and is considered less severe thanDebug
.Most severe level listed first:
I will update the affected repos:
To keep the current order of severity existing
Verbose
messages will be changed toDebug
and existingDebug
messages will be changed toTrace
.