This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Handle known headers with no value #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The old HttpListener code was about the same, except it didn't run through a decoder, it tried to directly marshal as a string. |
jkotalik
approved these changes
Oct 11, 2017
|
|
||
| var context = await server.AcceptAsync(Utilities.DefaultTimeout); | ||
| var requestHeaders = context.Request.Headers; | ||
| Assert.Equal(3, requestHeaders.Count); |
There was a problem hiding this comment.
So for these tests, are there always 3 default headers?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#381 The underlying decoders don't allow for length 0 strings. The code comment is pretty obvious, it's not clear why it didn't match the code.