Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

Handle known headers with no value #401

Merged
merged 1 commit into from
Oct 11, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ private string GetKnowHeaderHelper(HttpSysRequestHeader header, long fixup, Http
HttpApiTypes.HTTP_KNOWN_HEADER* pKnownHeader = (&request->Headers.KnownHeaders) + headerIndex;
// For known headers, when header value is empty, RawValueLength will be 0 and
// pRawValue will point to empty string ("\0")
if (pKnownHeader->pRawValue != null)
if (pKnownHeader->RawValueLength > 0)
{
value = HeaderEncoding.GetString(pKnownHeader->pRawValue + fixup, pKnownHeader->RawValueLength);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using System;
using System.Linq;
using System.Net.Http;
using System.Net.Sockets;
using System.Text;
Expand Down Expand Up @@ -93,6 +94,56 @@ public async Task RequestHeaders_ClientSendsUtf8Headers_Success()
}
}

[ConditionalFact]
public async Task RequestHeaders_ClientSendsKnownHeaderWithNoValue_Success()
{
string address;
using (var server = Utilities.CreateHttpServer(out address))
{
string[] customValues = new string[] { "" };
Task responseTask = SendRequestAsync(address, "If-None-Match", customValues);

var context = await server.AcceptAsync(Utilities.DefaultTimeout);
var requestHeaders = context.Request.Headers;
Assert.Equal(3, requestHeaders.Count);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for these tests, are there always 3 default headers?

Assert.Equal(new Uri(address).Authority, requestHeaders["Host"]);
Assert.Equal(new[] { new Uri(address).Authority }, requestHeaders.GetValues("Host"));
Assert.Equal("close", requestHeaders["Connection"]);
Assert.Equal(new[] { "close" }, requestHeaders.GetValues("Connection"));
Assert.Equal(StringValues.Empty, requestHeaders["If-None-Match"]);
Assert.Empty(requestHeaders.GetValues("If-None-Match"));
Assert.Equal("spacervalue", requestHeaders["Spacer-Header"]);
context.Dispose();

await responseTask;
}
}

[ConditionalFact]
public async Task RequestHeaders_ClientSendsUnknownHeaderWithNoValue_Success()
{
string address;
using (var server = Utilities.CreateHttpServer(out address))
{
string[] customValues = new string[] { "" };
Task responseTask = SendRequestAsync(address, "Custom-Header", customValues);

var context = await server.AcceptAsync(Utilities.DefaultTimeout);
var requestHeaders = context.Request.Headers;
Assert.Equal(4, requestHeaders.Count);
Assert.Equal(new Uri(address).Authority, requestHeaders["Host"]);
Assert.Equal(new[] { new Uri(address).Authority }, requestHeaders.GetValues("Host"));
Assert.Equal("close", requestHeaders["Connection"]);
Assert.Equal(new[] { "close" }, requestHeaders.GetValues("Connection"));
Assert.Equal("", requestHeaders["Custom-Header"]);
Assert.Empty(requestHeaders.GetValues("Custom-Header"));
Assert.Equal("spacervalue", requestHeaders["Spacer-Header"]);
context.Dispose();

await responseTask;
}
}

private async Task<string> SendRequestAsync(string uri)
{
using (HttpClient client = new HttpClient())
Expand Down