This repository has been archived by the owner on Nov 1, 2018. It is now read-only.
Switch to UsePathBase instead of relying on Kestrel feature #236 #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Assert.Null(builder.GetSetting(WebHostDefaults.ServerUrlsKey)); | ||
|
|
||
| // Adds a server and calls Build() | ||
| var server = new TestServer(builder); | ||
|
|
||
| Assert.Equal("http://localhost:12345/", builder.GetSetting(WebHostDefaults.ServerUrlsKey)); | ||
| Assert.Equal("http://localhost:12345", builder.GetSetting(WebHostDefaults.ServerUrlsKey)); |
There was a problem hiding this comment.
Slight behaviour change. Paths that represent empty paths will no longer be appended to the url address that the server sees.
|
|
| } | ||
|
|
||
| public Action<IApplicationBuilder> Configure(Action<IApplicationBuilder> next) | ||
| { | ||
| return app => | ||
| { | ||
| app.UsePathBase(_pathBase); |
There was a problem hiding this comment.
Can we just avoid the middleware if the pathbase is empty?
There was a problem hiding this comment.
That's being done in the middleware.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#236