This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Switch back to libuv as the default transport #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Jan 16, 2018
| @@ -30,7 +28,7 @@ public static IWebHostBuilder UseKestrel(this IWebHostBuilder hostBuilder) | |||
| return hostBuilder.ConfigureServices(services => | |||
| { | |||
| // Don't override an already-configured transport | |||
| services.TryAddSingleton<ITransportFactory, SocketTransportFactory>(); | |||
| services.AddSingleton<ITransportFactory, LibuvTransportFactory>(); | |||
There was a problem hiding this comment.
Either comment is wrong or you shouldn't use AddSingleton
|
@pakrym updated |
pakrym
approved these changes
Jan 16, 2018
davidfowl
approved these changes
Jan 16, 2018
muratg
approved these changes
Jan 17, 2018
halter73
force-pushed
the
halter73/2220
branch
from
d458a51 to
e54095c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2220