Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websockets tests broken by switching Kestrel back to libuv by default #2813

Closed
natemcmaster opened this issue Jan 19, 2018 · 5 comments
Closed
Assignees
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed feature-websockets Includes: WebSockets

Comments

@natemcmaster
Copy link
Contributor

Some tests started failing after aspnet/KestrelHttpServer#2257

  • Microsoft.AspNetCore.WebSockets.Test
  • Microsoft.AspNetCore.Proxy.Test.WebSocketsTest

http://aspnetci/viewLog.html?buildId=390091&tab=buildResultsDiv&buildTypeId=Lite_UniverseTest

cc @ryanbrandenburg

@halter73 can you take a look?

@natemcmaster
Copy link
Contributor Author

Failure:

System.IO.IOException : Failed to bind to address http://localhost:4001.
---- System.AggregateException : One or more errors occurred.
-------- System.DllNotFoundException : Unable to load DLL 'libuv': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

@halter73
Copy link
Member

Fixed by aspnet/WebSockets@ec442c3

@halter73 halter73 added the Done This issue has been fixed label Jan 23, 2018
@analogrelay
Copy link
Contributor

FYI, there are other tests (in Proxy) which have similar issues. And I'd imagine the various server/functional tests may have this issue to (depending on if they have the necessary MSBuild config applied). Perhaps we should try to put something in our common targets to enable this for all test projects. /cc @ryanbrandenburg @natemcmaster @halter73

@halter73
Copy link
Member

👍 It doesn't hurt to add the HasRuntimeOutput to all the test projects until the vstest issue is fixed, right?

@analogrelay
Copy link
Contributor

Yeah, that's what I suggested to @ryanbrandenburg earlier.

ryanbrandenburg pushed a commit that referenced this issue Nov 27, 2018
* Updated the lock files
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions Done This issue has been fixed feature-websockets Includes: WebSockets
Projects
None yet
Development

No branches or pull requests

5 participants