-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix websockets tests broken by switching Kestrel back to libuv by default #2813
Comments
Failure:
|
Fixed by aspnet/WebSockets@ec442c3 |
FYI, there are other tests (in Proxy) which have similar issues. And I'd imagine the various server/functional tests may have this issue to (depending on if they have the necessary MSBuild config applied). Perhaps we should try to put something in our common targets to enable this for all test projects. /cc @ryanbrandenburg @natemcmaster @halter73 |
👍 It doesn't hurt to add the HasRuntimeOutput to all the test projects until the vstest issue is fixed, right? |
Yeah, that's what I suggested to @ryanbrandenburg earlier. |
Some tests started failing after aspnet/KestrelHttpServer#2257
http://aspnetci/viewLog.html?buildId=390091&tab=buildResultsDiv&buildTypeId=Lite_UniverseTest
cc @ryanbrandenburg
@halter73 can you take a look?
The text was updated successfully, but these errors were encountered: