This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Fix comments, typos and add property validation to Microsoft.Extensions.Logging.AzureAppServices #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
changed the title
moozzyk
reviewed
Nov 3, 2016
| get { return _blobName; } | ||
| set | ||
| { | ||
| if (value == null) |
pakrym
force-pushed
the
pakrym/fix-comments
branch
from
b33b434 to
50a3881
Compare
|
|
||
| /// <summary> | ||
| /// Gets or sets a time to wait between checking for blob log batches. | ||
| /// Gets or sets a time to wait between checking for blob log batches. Defaults to 5 seconds. |
| /// <summary> | ||
| /// Gets or sets a strictly positive value representing the maximum log size in bytes. Once the log is full, no more message will be appended. | ||
| /// Gets or sets a strictly positive value representing the maximum log size in bytes. | ||
| /// Once the log is full, no more message will be appended. |
|
🚢 🇮🇹 |
pakrym
force-pushed
the
pakrym/fix-comments
branch
from
50a3881 to
bde89a0
Compare
Eilon
reviewed
Nov 4, 2016
| get { return _outputTemplate; } | ||
| set | ||
| { | ||
| if (string.IsNullOrWhiteSpace(value)) |
There was a problem hiding this comment.
Argh, why are we checking for whitespace??
| get { return _blobName; } | ||
| set | ||
| { | ||
| if (string.IsNullOrWhiteSpace(value)) |
| { | ||
| if (value < 0) | ||
| { | ||
| throw new ArgumentOutOfRangeException(nameof(value), $"{nameof(BackgroundQueueSize)} must be positive or 0."); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #508 #506 #507