Consume new Microsoft.AspNet.WebApi.Client.5.2.4 package

[dougbu]

Our Microsoft.AspNetCore.Mvc.WebApiCompatShim package currently has an indirect dependency on the Microsoft.Net.Http package. Building the shim project requires imports when targeting .NET Standard for the same reason. Both issues could be avoided if we moved to the latest Microsoft.AspNet.WebApi.Client package.

See also

• ASP.NET Core & System.Net.Http.Formatting #5562, an older report of related problems
• Publish at least the Microsoft.AspNet.WebApi.Client.5.2.4 package AspNetWebStack#45, tracking publishing the Microsoft.AspNet.WebApi.Client v5.2.4 package for realsies
• Add netstandard support to appropriate packages AspNetWebStack#4, which covered adding .NET Standard 1.1. support to the Microsoft.AspNet.WebApi.Client package
• the current Microsoft.AspNetCore.Mvc.WebApiCompatShim package
• the current Microsoft.AspNet.WebApi.Client package
• the new Microsoft.AspNet.WebApi.Client package

[Eilon]

This is approved, but let's figure out the plan to actually ship the 5.2.4 wave of packages.

[dougbu]

Should I go ahead with this in the meantime i.e. with the nightly ASP.NET feed in MVC's NuGet.config?

[Eilon]

We should talk about how to do the release and see if we can just do that.

[dougbu]

Side note: Fix here should include removing the last couple of $(PackageTargetFallback) aka "imports" from the MVC repo.

[Tornhoof]

Any plans for a public aspnet/AspNetWebStack?
Just asking as aspnet/AspNetKatana ist already public and some issues in aspnet link the private repo

[dougbu]

The first priority is to publish 3.2.4 / 5.2.4 packages from aspnet/AspNetWebStack or at least the Microsoft.AspNet.WebApi.Client.5.2.4 package on NuGet. But, yes, work to make that repo public is in progress.

[JunTaoLuo]

@Eilon were we going to remove this package? Is there an issue tracking that?

[Eilon]

Oops forgot to log an issue. I'll start a thread first. I'll actually go do that now.

[vanillajonathan]

@dougbu How is Microsoft.AspNet.WebApi.Client 5.2.4 coming along?

I would really like to see it on NuGet.

[dougbu]

@vanillajonathan the 5.2.4 package release is not yet available on NuGet. We've been consumed with 2.0.0-preview1 items and this is slated for 2.0.0-preview3.

[smarts]

@dougbu is 2.0.0-preview3 something we can expect in 2017?

[dougbu]

@smarts see https://github.com/aspnet/Home/wiki/Roadmap

[smarts]

thanks @dougbu

[vanillajonathan]

It would be really nice with a small intermediate NuGet release of Microsoft.AspNet.WebApi.Client with just support for netstandard asap so we can write against APIs on .NET Core using PostAsJsonAsync.

[dougbu]

@anurse please remind me what additional change needs to happen in aspnet/AspNetWebStack for the Microsoft.AspNet.WebApi.Client.5.2.4 package to work in the new .NET 4.6.1 world. Was it just the one item?

• add a .NET 4.6.1-specific <FrameworkReference>mscorlib</FrameworkReference>

[analogrelay]

That should do it. The goal is to ensure that there is a Framework Assembly Reference to mscorlib in the .NETFramework, Version=4.6.1 target framework in the final NuSpec, in order to suppress the System.Net.Http one that appears in the 4.5.1 target.

[aliostad]

According to this, yes. It will be all fixed in the next few hours, apparently.

[dscarmoz]

What is the ETA on 5.2.4? Having the same issue Vinhaman stated 8/21 --- I've tried to update my project to .net core 2.0 and i'm having some issues with the 5.2.3 (it builds but fails on execution due to dependencies of System.Net.Http.Primitives ...)

[Vinhaman]

Hi @dscarmoz
My workaround for this and many other problems was to change the target framework in all my projects to framework 4.6.1 (everything .net core 2 still works just fine).
Took me a few days to change everything we had but now is running smooth

[dscarmoz]

I don't think that will work for me. I'm running on a linux stack in PCF and the available buildpacks do not support it.

[dougbu]

• bab520f
• aspnet/HttpClientFactory@ded365f1ec
• aspnet/Universe@cedbbd8394

[Eilon]

@dougbu should we log another bug to update to 5.2.4 RTM? Though it's not likely we'll forget to do that, it's good to have an item tracking stuff we know we have to do.

[dougbu]

Well, if you weren't OOF, I would have asked you just that 😺 I'll file one…

The other thing I would have asked an in-person @Eilon: bab520f requires users to remove a previously-required <PackageTargetFallback> element or similar "must use PCL assembly" workaround from their projects. Should we document that as a full-blown breaking change? (I lean toward marking this bug with the label and adding a few words about the lines that should go but going no further.)

[Eilon]

Or leave the bug as-is, but post a breaking-change announcement about it. THat'll be especially helpful for release notes, etc.

[dougbu]

See #7212 for the follow-on work.

[asjafjell]

@anurse I have upgraded a .NET4.6 library to .NET 4.6.1 and it is complaining about missingSystem.Net.Http.HttpClientFactory.Create in some tests of mine. Is this something that can be fixed by adding a <FrameworkReference>mscorlib</FrameworkReference> to the Nuspec? Seems a bit odd as this will only affect consumers of my library, not making my tests green.

[dougbu]

@asjafjell please open a new issue for the problem you're seeing. Also, what is necessary to reproduce the problem and what are the details of the "complaining"?

[asjafjell]

@dougbu it seems to be automatic binding redirects that was my problem. I did not know that this would be an issue between 4.6.0 and 4.6.1, so by adding

<PropertyGroup>
    <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
    <GenerateBindingRedirectsOutputType>true</GenerateBindingRedirectsOutputType>
</PropertyGroup>

as indicated in dotnet/standard#481, the problem was fixed. The complaining, was that the method was missing runtime.

[dougbu]

New announcement (aspnet/Announcements#286) and discussion (#7229) issues are now live. I couldn't find a major break but the recommendation stands.