This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Remove constructor injection from TagHelper creation. #1307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTaylorMullen
force-pushed
the
TagHelpers_RemoveActivation
branch
from
55382b6 to
6af555a
Compare
|
|
||
| try | ||
| { | ||
| tagHelper = Activator.CreateInstance<TTagHelper>(); |
There was a problem hiding this comment.
Don't want to enforce TTagHelper to be new() because we want to throw a more informative error at runtime to point the user in the right direction.
There was a problem hiding this comment.
If you use new() constraint, you will get a compilation failure, not a runtime error.
|
|
- We now new up TagHelper's, requiring them to have parameterless constructors. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
NTaylorMullen
force-pushed
the
TagHelpers_RemoveActivation
branch
from
88ba8d0 to
6520ad2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag Helpers: Remove type activation for the creation of TagHelpers #1303