This repository was archived by the owner on Dec 14, 2018. It is now read-only.
[Design] Clean up logging. #2344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| Environment.NewLine, | ||
| finalMatches.Select(a => a.DisplayName)); | ||
| _logger.LogError( | ||
| $"Request matched multiple actions resulting in ambiguity. Matching actions: {actionNames}"); |
There was a problem hiding this comment.
Don't use $ - let logging handle it.
kichalla
force-pushed
the
kiran/logging-cleanup
branch
6 times, most recently
from
a55e2cf to
7c2538a
Compare
| @@ -9,10 +9,25 @@ namespace Microsoft.AspNet.Mvc | |||
| { | |||
| public class ActionDescriptor | |||
| { | |||
| private readonly Guid _guid; | |||
There was a problem hiding this comment.
Maybe save the string instead of the GUID?
kichalla
force-pushed
the
kiran/logging-cleanup
branch
from
af124cb to
d00db54
Compare
| public ActionDescriptor() | ||
| { | ||
| Properties = new Dictionary<object, object>(); | ||
| RouteValueDefaults = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase); | ||
| _guid = Guid.NewGuid().ToString(); |
There was a problem hiding this comment.
use _id or the Id property directly.
|
⌚ |
kichalla
force-pushed
the
kiran/logging-cleanup
branch
3 times, most recently
from
aa959aa to
e25ab19
Compare
|
Updated. /cc: @rynowak |
|
|
- Removing scopes as we want to limit the number of scopes being created. - Added new log statements using the new log format string.
kichalla
force-pushed
the
kiran/logging-cleanup
branch
from
e25ab19 to
24b930f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: I have not yet modified the tests to reflect these changes. Will update them once the design looks ok.
Related PR in routing which has been updated: aspnet/Routing#172
/cc: @rynowak