This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Find IDocumentProvider using a more-laborious process
#8590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would like to get this into the feature branch soon 😃 |
dougbu
changed the base branch from
feature/client.code.generation
to
release/2.2
|
Changed base now that I've merged |
dougbu
force-pushed
the
dougbu/not.type.gettype
branch
from
d2d253d to
6559a1b
Compare
dougbu
force-pushed
the
dougbu/not.type.gettype
branch
from
6559a1b to
064ec5c
Compare
|
🆙📅 |
pranavkm
approved these changes
Oct 18, 2018
rynowak
reviewed
Oct 18, 2018
rynowak
reviewed
Oct 18, 2018
rynowak
reviewed
Oct 18, 2018
rynowak
suggested changes
Oct 18, 2018
dougbu
force-pushed
the
dougbu/not.type.gettype
branch
from
064ec5c to
dcbd780
Compare
|
🆙📅 @rynowak do you want to take one more look? |
rynowak
approved these changes
Oct 27, 2018
- #8593 - also find `IDocumentProvider` using a more-laborious process - `Type.GetType(string)` requires an assembly-qualified name and we don't know the assembly - default method name now `GenerateAsync` - only supported signature is `public Task GenerateAsync(string, TextWriter)` also: - handle more error cases in the tool's inside man - avoid an empty document file if `IDocumentProvider.GenerateAsync(...)` fails - unwrap an `AggregateException` nits: - remove duplicate comments - change `GetDocumentCommandWorker.TryProcess(...)` to return `false` on failure - minor because return value is currently ignored - rename `GetDocumentCommandContext.Output` -> `OutputPath` - reflect recent change to `dotnet-getdocument`'s `Resources.resx` file in its designer file
dougbu
force-pushed
the
dougbu/not.type.gettype
branch
from
dcbd780 to
7ae3578
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type.GetType(string)requires an assembly-qualified name and we don't know the assemblynit:
dotnet-getdocument'sResources.resxfile in its designer file