This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Update MVC to use routing required values for endpoints #8731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
commented
Nov 16, 2018
src/Microsoft.AspNetCore.Mvc.Core/Routing/MvcEndpointDataSource.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.AspNetCore.Mvc.Core/Routing/MvcEndpointDataSource.cs
Outdated
Show resolved
Hide resolved
JamesNK
commented
Nov 21, 2018
| @@ -12,8 +12,8 @@ | |||
| <body> | |||
| <h1 style="font-family: cursive;">ASP.NET vNext - About</h1> | |||
| <p>| <a href="/" style="background-color: gray;color: white;border-radius: 3px;border: 1px solid black;padding: 3px;font-family: cursive;">My Home</a> | |||
| | <a href="/Home/About" style="background-color: gray;color: white;border-radius: 3px;border: 1px solid black;padding: 3px;font-family: cursive;">My About</a> | |||
| | <a href="/Home/Help" style="background-color: gray;color: white;border-radius: 3px;border: 1px solid black;padding: 3px;font-family: cursive;">My Help</a> |</p> | |||
| | <a href="/home/about" style="background-color: gray;color: white;border-radius: 3px;border: 1px solid black;padding: 3px;font-family: cursive;">My About</a> | |||
There was a problem hiding this comment.
This change is actually going back to 2.1 behavior
JamesNK
changed the title
|
Builds and tests locally. Unable to complete at the moment without a feature branch build. |
rynowak
reviewed
Nov 22, 2018
| @@ -5,6 +5,7 @@ | |||
| <RestoreSources>$(DotNetRestoreSources)</RestoreSources> | |||
| <RestoreSources Condition="'$(DotNetBuildOffline)' != 'true' AND '$(AspNetUniverseBuildOffline)' != 'true' "> | |||
| $(RestoreSources); | |||
| C:\Development\Source\Routing\artifacts\build; | |||
rynowak
reviewed
Nov 22, 2018
| defaults[kvp.Key] = kvp.Value; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Yeah. I think we came up with a better design 😁
rynowak
reviewed
Nov 22, 2018
| }); | ||
| } | ||
| //[Fact] | ||
| //public void Endpoints_AttributeRoutes_ActionMetadataDoesNotOverrideDataSourceMetadata() |
There was a problem hiding this comment.
Should this still be commented out ???
rynowak
reviewed
Nov 22, 2018
| @@ -323,7 +323,7 @@ public async Task PagesInAreas_CanGenerateLinksToControllersAndPages() | |||
| var expected = | |||
| @"<a href=""/Accounts/Manage/RenderPartials"">Link inside area</a> | |||
| <a href=""/Products/List/old/20"">Link to external area</a> | |||
| <a href=""/Accounts"">Link to area action</a> | |||
| <a href="""">Link to area action</a> | |||
There was a problem hiding this comment.
I think it would be good to change to the test code to be successful, or even better skip the test and link to the issue.
rynowak
suggested changes
Nov 22, 2018
|
Replaced with PR on aspnetcore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring what MVC code would look like when consuming RoutePatternTransformer.
Neither tests or routing are updated yet so everything will fail.