[Routing] [Mvc] Support RoutePattern required values in matcher and link generator

[JamesNK]

• DFA matcher uses required values to denormalize routes
• Link generator uses required values to calculate route precedence
• Obsolete IRouteValuesAddressMetadata
• React in MVC to provide required values with RoutePattern in datasource

re: aspnet/Routing#914 and aspnet/Mvc#8731

[JamesNK]

@ryanbrandenburg @natemcmaster I just want to double check with you guys whether there is anything new or different when creating PRs in this post-mondo world. Any tricks or tips?

[JamesNK]

@ryanbrandenburg @natemcmaster Do feature branches work the same way in the new world?

I need to make updates to MVC with this PR's changes. Can that happen while MVC is non-mondo, or should it wait until MVC is migrated?

[JamesNK]

@mkArtakMSFT FYI the breaking change here is IRouteValuesAddressMetadata is no longer used for required values. It has moved to RoutePattern.RequiredValues.

IRouteValuesAddressMetadata was introduced in 2.2 and I doubt anyone would use it beside us.

Edit:
Additional breaking change in this PR around MVC link generation. More detail here - #4212

[natemcmaster]

We we're planning on getting MVC merged to this repo today so that you would have been able to make both changes at the same time. Unfortunately, other stuff got in the way so merging MVC got pushed to tomorrow. Once it is in, you can make the changes to routing and MVC projects in the same branch.

[JamesNK]

Ok, I'll wait until tomorrow.

Question about cross-solution changes: Under the routing directory there is still a build dir with a dependencies file in it. If I update the MVC solution and Routing solution at the same time, how do the Routing changes get used in MVC immediately?

[natemcmaster]

how do the Routing changes get used in MVC immediately?

The dependencies file in src/*/build/ will eventually go away completely. That file is only used if you run src/*/build.cmd scripts. When the root-level build.cmd script is invoked, it does some fancy stuff generate a props file which ensures package versions are aligned.

https://github.com/aspnet/AspNetCore/blob/a0d1b8882b35820cb38e4683dc9b282d5a3b2017/build/RepositoryBuild.targets#L83

This is why all src/*/build/dependencies.props files are required to have this import:
https://github.com/aspnet/AspNetCore/blob/a0d1b8882b35820cb38e4683dc9b282d5a3b2017/src/AuthSamples/build/dependencies.props#L75

FYI Phase 1 of mondo-repo was to get all source in the same place. Phase 2 is #4246 (which has already started) which should make it even easier to make changes to multiple areas of the product at the same time.

[JamesNK]

Thanks for the info, I'm looking forward to phase 2!

For this PR, what do I need to do today for cross-solution changes? 😸 @rynowak wants to build on top of these changes and is blocked until we can get this merged

[rynowak]

This looks like what I remember from the aspnet/Routing PR 👍

[JamesNK]

@rynowak Still blocked until #4273 is merged. Fingers crossed I can get it in tomorrow

Added MVC reaction

[JamesNK]

🆙 📅 @rynowak

It builds. Tests fail but I believe they were already failing.

[rynowak]

I think I left this comment as my only feedback on the aspnet/Mvc PR.... why not change the test to do something valid?

I'm not sure I care a whole ton about this part because I think we will have to restore the 2.1/2.2 behaviour. I think it's fine to do that after this PR.