Mondo master: SignalR Mvc MvcPrecompilation and Razor #4273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-master [automated] Merge branch 'release/2.2' => 'master'
Addresses a blocking issue for FAR of types when used in user-code in a directive. The FAR infrastructure is skipping over the directive code because it's mapped to `#hidden`. As you can see in the code, the token provided by the user is already included in the projection mappings. I think we didn't do this before because we didn't expect this code to need line numbers - it's not really debuggable, and design-time codegen doesn't happen when you build the project. I think it's OK for now that we don't line-map (or include) directives based on view imports. If you trigger FAR on an `@inject ...` in an import for instance, you'll find the reference for the view import file. That seems pretty good, and the only cases I can really imagine it being broken would be for go-to-definition (within a Razor view). Lets revisit in the future based on feedback.
This wasn't quite doing the right thing, and it's simpler than we make it to be.
So, it turns out the VSSDK added a feature that lets us suppress assemblies brought in by package references. YAY!
To enable custom handling of antiforgery validation failures, use an `AntiforgeryValidationFailedResult` which is just a `BadRequestResult` but allows to be identified explicitly inside always-running result filters using the `IAntiforgeryValidationFailedResult` marker interface.
…-master [automated] Merge branch 'release/2.2' => 'master'
…-master [automated] Merge branch 'release/2.2' => 'master'
…semblies in C#. - Added a layer of indirection to allow for proper Lazy loading of Razor and future async completion specific assemblies.
This builds support for tracking the effect of changes to imports on other documents, and completes our model for being able to keep generated code up to date.
This doesn't really accomplish our goals for 2.2 - I don't have a clear scenario where I would tell a developer to use this VS something else. Will reevaluate in 3.0
…-master [automated] Merge branch 'release/2.2' => 'master'
Merge release/2.2 Remove functional interfaces (#3165)
This change adds mock ups of the interfaces that we've been designing as part of Razor FAR as well as the implementations. This isn't wired up to anything yet in this PR, but the basic functionality here is stable enough for us to stabilize and review. For now we have the interface definitions in the Razor codebase until a build of Roslyn is available with these definitions + IVT for us to use them.
…-master [automated] Merge branch 'release/2.2' => 'master'
…-master [automated] Merge branch 'release/2.2' => 'master'
…rc' into rybrande/Mondo2.2
Prior to reorganization, this source code was found in https://github.com/aspnet/SignalR/tree/c852bdcc332ffb998ec6a5b226e35d5e74d24009
Prior to reorganization, this source code was found in https://github.com/aspnet/Mvc/tree/c9887e027a97b07a3ae7699112b9a2620a36e553
Prior to reorganization, this source code was found in https://github.com/aspnet/MvcPrecompilation/tree/3cd4de8af8322b90e62a5818ece90428e2dc933b
Prior to reorganization, this source code was found in https://github.com/aspnet/Razor/tree/582f3f867eeb8fca00e6b328faf7665c9a98476c
… into rybrande/MondoMaster
|
|
||
| <PropertyGroup> | ||
| <Product>Microsoft ASP.NET Core MVC</Product> | ||
| <RepositoryUrl>https://github.com/aspnet/Mvc</RepositoryUrl> |
There was a problem hiding this comment.
Can you update this value too? We should probably go back and cleanup this up for everything in 2.1 as well.
natemcmaster
approved these changes
Nov 27, 2018
|
@ryanbrandenburg Make sure the gradlew file is executable #4275 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.