Move binaries in to the build folder #145
Conversation
| </Target> | ||
|
|
||
| <Target | ||
| Name="_AddDesktopReferences" |
There was a problem hiding this comment.
Not super sure if this works - I have to try creating a mismatch in Mvc versions between the project and the tool which I haven't gotten around to as yet.
| <None Include="$(X86ProjectDirectory)\bin\$(Configuration)\net461\win7-x86\$(AssemblyName)-x86.exe" Pack="true" PackagePath="runtimes\win7-x86\lib\net461\$(AssemblyName)-x86.exe" /> | ||
| <None Include="build\**\*.*" Pack="true" PackagePath="%(Identity)" /> | ||
| <None Include="$(OutputPath)netcoreapp2.0\$(AssemblyName).dll" Pack="true" PackagePath="build\netstandard2.0\$(AssemblyName).dll" /> | ||
| <None Include="$(OutputPath)net461\win7-x64\$(AssemblyName).exe" Pack="true" PackagePath="build\netstandard2.0\$(AssemblyName)-x64.exe" /> |
There was a problem hiding this comment.
How will you handle binding redirects? This wont get them auto-generated for you anymore.
There was a problem hiding this comment.
I added the binary as a reference as part of _AddDesktopReferences. See my earlier comment
There was a problem hiding this comment.
oooo that's what you meant there. I see. Ya would be super curious if that works.
There was a problem hiding this comment.
So when packaging this guy and installing on a local app does it work?
There was a problem hiding this comment.
Not sure what that means?
There was a problem hiding this comment.
You made it seem like you weren't sure if this worked. After testing, does it work?
There was a problem hiding this comment.
Yup, seems to work. I built Mvc 2.1.0.
<assemblyBinding xmlns="urn:schemas-microsoft-com:asm.v1">
<dependentAssembly>
<assemblyIdentity name="Microsoft.AspNetCore.Mvc.Core" publicKeyToken="adb9793829ddae60" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-2.1.0.0" newVersion="2.1.0.0" />
</dependentAssembly>
</assemblyBinding>
I might be able to hack a fake Microsoft.AspNetCore.Mvc package to test this out on an ongoing basis.
| @@ -12,6 +12,4 @@ | |||
| <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="$(AspNetCoreVersion)" /> | |||
| </ItemGroup> | |||
|
|
|||
| <Target Name="PrecompileRazorViews" AfterTargets="Build" DependsOnTargets="MvcRazorPrecompile" Condition="'$(TargetFramework)'!=''" /> | |||
There was a problem hiding this comment.
This fixes #117. We explicitly call precompilation on the project from the consuming project.
|
New directory structure with this change: |
|
Ya this is awesome 👍 |
|
Travis looks to be exploding however. |
|
Travis is sorted - I thought I could remove this - https://github.com/aspnet/MvcPrecompilation/pull/145/files#diff-4d5e7369a237e37020f01b3b255505e0L35 but seemingly not. |
Maybe fixes #143