-
Notifications
You must be signed in to change notification settings - Fork 129
V 2.0.2 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Austio
wants to merge
104
commits into
assembler:master
Choose a base branch
from
doximity:v-2.0.2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V 2.0.2 #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that belongs_to is required by default at Rails 5 we need to add the `inverse_of`option to has_many on the owner object or you will receive a validation error when you create try create it.
Update from upstream
Fix for Active Record callbacks to enable Rails 5 compatibility
need coffee-script and can loose cloudinary version
CORS support should be opt-in
Add Rails 5 support
Replacing symbolize_keys! with symbolize_keys
Honor resource type on destroy and tag removal
This commit provides a default options for as_json method in the FileMixin module.
This is to prevent the error that occurs when the as_json method is called without any options.
The default options are set to an empty hash.
This error was discovered when upgrading the wiki to Ruby 3.3.6
```
level":"fatal","tags":["d3ddc515-ac56-4706-9b85-d611a3c88f28"],"name":"Rails","exception":{"name":"ActionView::Template::Error","message":"wrong number of arguments (given 0, expected 1)","stack_trace":["/workspace/vendor/cache/attachinary-a72d9b6c151f/lib/attachinary/orm/file_mixin.rb:12:in `as_json'"
```
…pgrade Update FileMixin as_json for Ruby 3.3.6 upgrade of Wiki
Fixup gem for publishing
Update readme
…f the engine and file name. Update our engine integration to only include one named initializer so that it will not error out
Support Rails 8.1+ initialize method expectations
Update version to 2.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Republishing