Skip to content

Commit

Permalink
♿️ vue-dot: Add aria-label on close button in DialogBox (#1892)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dylan Broussard authored Apr 6, 2022
1 parent e329f25 commit 7d2aa84
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@

- 🐛 **Corrections de bugs**
- **ExternalLinks:** Correction de l'affichage du menu ([#1889](https://github.com/assurance-maladie-digital/design-system/pull/1889)) ([e6f1b7f](https://github.com/assurance-maladie-digital/design-system/commit/e6f1b7f32b55fcf51cd70b0bd413cb13383ffef9))
- **DialogBox:** Correction de l'alignement du titre ([#1890](https://github.com/assurance-maladie-digital/design-system/pull/1890))
- **DialogBox:** Correction de l'alignement du titre ([#1890](https://github.com/assurance-maladie-digital/design-system/pull/1890)) ([e329f25](https://github.com/assurance-maladie-digital/design-system/commit/e329f252e1314d31effc426d91ef9215ed8a589a))

- ♿️ **Accessibilité**
- **DialogBox:** Ajout de l'attribut `aria-label` sur le bouton fermer ([#1891](https://github.com/assurance-maladie-digital/design-system/pull/1891))

### Documentation

Expand Down
3 changes: 3 additions & 0 deletions packages/vue-dot/src/elements/DialogBox/DialogBox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

<VBtn
v-bind="options.closeBtn"
:aria-label="locales.closeBtn"
@click="close"
>
<VIcon v-bind="options.icon">
Expand Down Expand Up @@ -107,6 +108,8 @@
}
})
export default class DialogBox extends MixinsDeclaration {
locales = locales;
closeIcon = mdiClose;
get dialog(): boolean {
Expand Down
1 change: 1 addition & 0 deletions packages/vue-dot/src/elements/DialogBox/locales.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export const locales = {
closeBtn: 'Fermer la boîte de dialogue',
cancelBtn: 'Annuler',
confirmBtn: 'Valider'
};
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ exports[`DialogBox renders correctly 1`] = `
<vcardtitle-stub tag="div" class="d-flex align-start flex-nowrap pa-0 mb-6">
<!---->
<vspacer-stub tag="div"></vspacer-stub>
<vbtn-stub height="32px" width="32px" tag="button" activeclass="" icon="true" type="button" class="mt-n2 mr-n2 ml-4">
<vbtn-stub height="32px" width="32px" tag="button" activeclass="" icon="true" type="button" aria-label="Fermer la boîte de dialogue" class="mt-n2 mr-n2 ml-4">
<vicon-stub>
M19,6.41L17.59,5L12,10.59L6.41,5L5,6.41L10.59,12L5,17.59L6.41,19L12,13.41L17.59,19L19,17.59L13.41,12L19,6.41Z
</vicon-stub>
Expand Down

0 comments on commit 7d2aa84

Please sign in to comment.