Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿️ vue-dot: Add aria-label on close button in DialogBox #1892

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

deraw
Copy link
Member

@deraw deraw commented Apr 6, 2022

Description

Ajout de l'attribut aria-label sur le bouton fermer dans le composant DialogBox.

Type de changement

  • Correction de bug

Checklist

  • Ma Pull Request pointe vers la bonne branche
  • Mon code suit le style de code du projet
  • J'ai effectué une review de mon propre code
  • J'ai commenté mon code, en particulier dans les parties difficiles à comprendre
  • J'ai apporté les modifications correspondantes à la documentation
  • Mes modifications ne génèrent aucun nouveau warning
  • J'ai ajouté des tests qui prouvent que mon correctif est efficace ou que ma fonctionnalité fonctionne
  • Les tests unitaires passent localement avec mes modifications
  • J'ai mis à jour le fichier Changelog

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1892 (5f8595b) into dev (e329f25) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #1892   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          178       178           
  Lines         1188      1188           
  Branches       157       157           
=========================================
  Hits          1188      1188           
Impacted Files Coverage Δ
packages/vue-dot/src/elements/DialogBox/locales.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e329f25...5f8595b. Read the comment docs.

@deraw deraw merged commit 7d2aa84 into dev Apr 6, 2022
@deraw deraw deleted the vue-dot/fix/dialog-box-a11y branch April 6, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant