[ruff] - fix false positive for decorators (RUF028) (#14061)

astral-sh · Nov 3, 2024 · ae9f08d · ae9f08d
1 parent f69712c
commit ae9f08d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/crates/ruff_linter/resources/test/fixtures/ruff/RUF028.py b/crates/ruff_linter/resources/test/fixtures/ruff/RUF028.py
@@ -87,3 +87,17 @@ def match_case_and_elif():
                 pass
             elif string == "Hello": # fmt: skip
                 pass
+
+
+# Regression test for decorators
+import pytest
+
+@pytest.mark.parametrize(
+    "test_input,expected",
+     [
+          ("3+5",  8 ),
+          ("17+2", 19),
+     ],
+)  # fmt: skip
+def test_eval(test_input, expected):
+    assert eval(test_input) == expected
diff --git a/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs b/crates/ruff_linter/src/rules/ruff/rules/invalid_formatter_suppression_comment.rs
@@ -278,6 +278,7 @@ const fn is_valid_enclosing_node(node: AnyNodeRef) -> bool {
         | AnyNodeRef::StmtIpyEscapeCommand(_)
         | AnyNodeRef::ExceptHandlerExceptHandler(_)
         | AnyNodeRef::MatchCase(_)
+        | AnyNodeRef::Decorator(_)
         | AnyNodeRef::ElifElseClause(_) => true,
 
         AnyNodeRef::ExprBoolOp(_)
@@ -333,7 +334,6 @@ const fn is_valid_enclosing_node(node: AnyNodeRef) -> bool {
         | AnyNodeRef::Keyword(_)
         | AnyNodeRef::Alias(_)
         | AnyNodeRef::WithItem(_)
-        | AnyNodeRef::Decorator(_)
         | AnyNodeRef::TypeParams(_)
         | AnyNodeRef::TypeParamTypeVar(_)
         | AnyNodeRef::TypeParamTypeVarTuple(_)